envoy: Silently discard expected warnings if flowdebug is not enabled #15284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envoy 1.17 keeps warning about a known runtime singleton issue which will not be fixed before Envoy release 1.18. Silently drop this warnings unless flowdebug is enabled (via --debug-verbose=flow). Remove this special treatment when the upstream envoy issue envoyproxy/envoy#13504 is fixed. Fixes: cilium#14919 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jrajahalme
added
area/proxy
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
test-me-please |
joestringer
approved these changes
Mar 9, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out one Envoy warning repeating multiple times (~ once per core available to Envoy):
There is an upstream issue tracking it's resolution: envoyproxy/envoy#13504. Apparently this will be fixed for the next Envoy release (1.18). Left a TODO in the source to remind removing this special treatment once upstream has been fixed.
Fixes: #14919
Signed-off-by: Jarno Rajahalme jarno@covalent.io