loader : Log upsert and remove route errors #15339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
pchaigno
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
added
the
sig/datapath
pchaigno
reviewed
Mar 15, 2021
pchaigno
reviewed
Mar 15, 2021
pchaigno
approved these changes
Mar 15, 2021
|
@pchaigno Thank You for the help . |
christarazi
requested changes
Mar 22, 2021
Fixes : cilium#15282 Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
christarazi
approved these changes
Mar 23, 2021
|
test-me-please |
aanm
reviewed
Mar 29, 2021
| if ep.RequireEndpointRoute() { | ||
| upsertEndpointRoute(ep, *ip.IPNet(32)) | ||
| if err := upsertEndpointRoute(ep, *ip.IPNet(32)); err != nil { | ||
| scopedLog.WithError(err).Warn("Failed to upsert route") |
There was a problem hiding this comment.
@pchaigno these are warnings, which steps can users perform if they see these?
There was a problem hiding this comment.
Same as for other similar warnings (e.g., warning when we fail to load the BPF program for an endpoint): they should investigate and/or report the warning, but it's probably not blocking/fatal for the Cilium agent.
aanm
pushed a commit
that referenced
this pull request
Mar 31, 2021
This reverts commit 32284cd. It seems like PR #15339 introduced a regression on Kernel 4.9 with the two following tests failing: - K8sDatapathConfig Encapsulation Check vxlan connectivity with per-endpoint routes - K8sDatapathConfig Host firewall With VXLAN and endpoint routes Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #15282
Signed-off-by: Gaurav Genani h3llix.pvt@gmail.com