Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: example cluster-wide health endpoint #15348

Merged
merged 1 commit into from
Mar 24, 2021
Merged

docs: example cluster-wide health endpoint #15348

merged 1 commit into from
Mar 24, 2021

Conversation

Shikugawa
Copy link
Contributor

Signed-off-by: Shikugawa Shikugawa@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #14871

This PR adds some descriptions and examples to configure cluster-wide health endpoint.

@Shikugawa Shikugawa requested a review from a team as a code owner March 15, 2021 13:42
@Shikugawa Shikugawa requested review from a team, qmonnet and jrajahalme March 15, 2021 13:42
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 15, 2021
qmonnet
qmonnet requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! This looks good to me on the documentation side, please just find a nitpick below.

Also, sorry to ask, but did you use your real name in the Signed-off-by: tag? Please note that this cannot be a pseudonym.

Documentation/policy/intro.rst Outdated Show resolved Hide resolved
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Mar 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2021
@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Mar 15, 2021
@qmonnet qmonnet requested a review from pchaigno March 15, 2021 14:09
@Shikugawa
Copy link
Contributor Author

Shikugawa commented Mar 15, 2021 •
edited

Also, sorry to ask, but did you use your real name in the Signed-off-by: tag? Please note that this cannot be a pseudonym.

@qmonnet Ah, sorry. I will fix it.

@pchaigno pchaigno added the gsoc Potential GSoC project or pull request related to GSoC label Mar 15, 2021
pchaigno
pchaigno requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! 🚀

I don't think the policy for the health endpoint is correct. It would probably be worth testing if you haven't already.

Documentation/policy/intro.rst Outdated Show resolved Hide resolved
examples/policies/kubernetes/clusterwide/health.yaml Outdated Show resolved Hide resolved
@Shikugawa Shikugawa force-pushed the fix-14871 branch 2 times, most recently from 859807c to c822677 Compare March 15, 2021 18:30
qmonnet
qmonnet requested changes Mar 16, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the message and the SOB tag!

One more remark on the new version, below.

Please also note that your changes belong to a single logical commit. This is not an issue to have several commits with your incremental changes for the review, but you'll need to squash them and to force-push on your branch at some point before we merge the PR.

Documentation/policy/intro.rst Outdated Show resolved Hide resolved
@pchaigno pchaigno mentioned this pull request Mar 16, 2021
Closed
@pchaigno pchaigno requested a review from qmonnet March 17, 2021 06:14
pchaigno
pchaigno approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the commits into a single one? We should be good to merge after that.

@pchaigno pchaigno removed their assignment Mar 17, 2021
@Shikugawa
docs: example cluster-wide health endpoint
d0eea23 
Signed-off-by: Rei Shimizu <Shikugawa@gmail.com>
qmonnet
qmonnet approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@qmonnet qmonnet removed their assignment Mar 17, 2021
@pchaigno
Copy link
Member

I don't think we need to wait for the @cilium/policy review as I tested this. Marking as ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 23, 2021
@brb brb merged commit 5476889 into cilium:master Mar 24, 2021
1.10.0 automation moved this from In progress to Done Mar 24, 2021
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@jrajahalme jrajahalme

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. gsoc Potential GSoC project or pull request related to GSoC ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document CCNP for the health endpoint
5 participants
@Shikugawa @pchaigno @qmonnet @brb @jrajahalme