Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Upgrade github.com/cilium/ebpf to v0.5.0 #15386

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

aditighag
Copy link
Member

@aditighag aditighag commented Mar 18, 2021

@aditighag aditighag requested a review from a team as a code owner March 18, 2021 15:42
@aditighag aditighag requested a review from rolinh March 18, 2021 15:42
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 18, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 18, 2021
@aditighag aditighag marked this pull request as draft March 18, 2021 15:42
@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Mar 18, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 18, 2021
@aditighag aditighag marked this pull request as ready for review March 18, 2021 15:49
@aditighag aditighag closed this Mar 18, 2021
@aditighag aditighag reopened this Mar 18, 2021
@rolinh
Copy link
Member

rolinh commented Mar 18, 2021

@aditighag The failure looks legit. Please run the following:

go mod tidy && go mod vendor && go mod verify

@aditighag
Copy link
Member Author

@aditighag The failure looks legit. Please run the following:

go mod tidy && go mod vendor && go mod verify

I had already run the first two. Let me see what the 3rd command does. Thanks!

@rolinh
Copy link
Member

rolinh commented Mar 18, 2021

I had already run the first two. Let me see what the 3rd command does. Thanks!

Make sure you use Go 1.16 as well.

@aditighag aditighag marked this pull request as draft March 18, 2021 16:32
@aditighag aditighag force-pushed the upgrade-cilium-ebpf branch 2 times, most recently from f87c316 to acc2c6e Compare March 18, 2021 23:17
@aditighag
Copy link
Member Author

aditighag commented Mar 18, 2021

I missed committing some unversioned files after running go mod tidy && go mod vendor so that's why the tests were failing.

@aditighag
Copy link
Member Author

There is a bug in the released version so I'll hold off on this PR for now. I'll follow up to see what the plan is for the bug fix.

@aditighag aditighag changed the title vendor: Upgrade github.com/cilium/ebpf to v0.4.0 vendor: Upgrade github.com/cilium/ebpf to v0.5.0 Apr 8, 2021
@aditighag aditighag force-pushed the upgrade-cilium-ebpf branch 2 times, most recently from 88e353a to dd26d4d Compare April 8, 2021 16:58
@aditighag
Copy link
Member Author

test-me-please

@aditighag
Copy link
Member Author

aditighag commented Apr 8, 2021

I don't understand why go-mod check is failing -

please run 'go mod tidy && go mod vendor', and submit your changes
Error: Process completed with exit code 1.

I've already run go mod tidy && go mod vendor locally before pushing the changes. There are no other changes in the README file that it is flagging.

Edit: The file was renamed, but git on mac OSx failed to recognize the change. Thanks @glibsm for pointing this out.

@aditighag
Copy link
Member Author

test-me-please

@aditighag aditighag marked this pull request as ready for review April 8, 2021 18:05
@aditighag aditighag requested a review from a team April 8, 2021 18:05
@aditighag aditighag requested a review from a team as a code owner April 8, 2021 18:05
@aditighag aditighag requested a review from jrfastab April 8, 2021 18:05
@rolinh rolinh removed their assignment Apr 8, 2021
@aditighag
Copy link
Member Author

test-1.16-netnext

@aditighag
Copy link
Member Author

test-1.20-4.19

@pchaigno
Copy link
Member

pchaigno commented Apr 9, 2021

@aditighag What failed? Are there already issues for those flakes?

@aditighag
Copy link
Member Author

I saw that these tests failed on other PRs, and they were flakes. My changes shouldn't cause any failures considering all but 2 tests have passed. Looks like both the tests passed on the retry.

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 9, 2021
@pchaigno
Copy link
Member

pchaigno commented Apr 9, 2021

I saw that these tests failed on other PRs, and they were flakes.

If there weren't issues for those, would be good to create them.

@pchaigno pchaigno merged commit 5849c3d into cilium:master Apr 9, 2021
1.10.0 automation moved this from In progress to Done Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants