Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add e2e tests for fromEntities: cluster and all #15398

Merged
merged 1 commit into from
Apr 9, 2021
Merged

test: add e2e tests for fromEntities: cluster and all #15398

merged 1 commit into from
Apr 9, 2021

Conversation

chez-shanpu
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Add e2e test for checking fromEntities: cluster and fromEntities: all

Fixes: #10979

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 19, 2021
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake gsoc Potential GSoC project or pull request related to GSoC release-note/ci This PR makes changes to the CI. labels Mar 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 19, 2021
@chez-shanpu chez-shanpu marked this pull request as ready for review March 19, 2021 15:37
@chez-shanpu chez-shanpu requested a review from a team as a code owner March 19, 2021 15:37
pchaigno
pchaigno requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

I think there are a couple more changes needed 👇

test/k8sT/Policies.go Outdated Show resolved Hide resolved
test/k8sT/Policies.go Outdated Show resolved Hide resolved
test/k8sT/Policies.go Outdated Show resolved Hide resolved
@chez-shanpu chez-shanpu force-pushed the add-e2e-fromentities-policies branch from 668daf8 to c9f71d5 Compare March 27, 2021 04:34
@pchaigno pchaigno mentioned this pull request Mar 29, 2021
Closed
5 tasks
@nathanjsweet
Copy link
Member

retest-netnext

@nathanjsweet
Copy link
Member

nathanjsweet commented Mar 29, 2021 •
edited

#15166 #14608 #15469, gke is good, but need to retest 4.9, 4.19, net-next

@nathanjsweet
Copy link
Member

retest-4.19

@nathanjsweet
Copy link
Member

retest-4.9

jrajahalme
jrajahalme requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but needs small fixes :-)

test/k8sT/Policies.go Show resolved Hide resolved
test/k8sT/Policies.go Outdated Show resolved Hide resolved
@chez-shanpu chez-shanpu force-pushed the add-e2e-fromentities-policies branch 2 times, most recently from 27b97f8 to b0802a2 Compare March 31, 2021 05:21
@chez-shanpu chez-shanpu force-pushed the add-e2e-fromentities-policies branch from b0802a2 to be15c42 Compare March 31, 2021 08:53
pchaigno
pchaigno approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit below. LGTM otherwise!

test/k8sT/Policies.go Outdated Show resolved Hide resolved
@chez-shanpu chez-shanpu force-pushed the add-e2e-fromentities-policies branch from be15c42 to 8da917b Compare March 31, 2021 13:36
@chez-shanpu
Copy link
Contributor Author

Thanks!
OK, I'll run it in my local env.

@chez-shanpu chez-shanpu force-pushed the add-e2e-fromentities-policies branch from acafa99 to da9966e Compare April 9, 2021 15:30
@chez-shanpu
test: add tests for fromEntities: cluster and all
578d302 
Add e2e test for checking `fromEntities: cluster` and `fromEntities: all`.
And also add a check for pod-to-pod connectivity and ingress connectivity from "world".

Related: cilium#10979

Signed-off-by: Tomoki Sugiura <cheztomo513@gmail.com>
@chez-shanpu chez-shanpu force-pushed the add-e2e-fromentities-policies branch from da9966e to 578d302 Compare April 9, 2021 16:33
@pchaigno
Copy link
Member

pchaigno commented Apr 9, 2021

test-me-please

@pchaigno pchaigno added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Apr 9, 2021
@pchaigno pchaigno merged commit 2400042 into cilium:master Apr 9, 2021
1.10.0 automation moved this from In progress to Done Apr 9, 2021
This was referenced Apr 28, 2021
Closed
Merged
@vadorovsky vadorovsky mentioned this pull request May 19, 2021
Merged
@vadorovsky
Copy link
Member

Needed for 1.9 to solve conflict with #16064

@vadorovsky vadorovsky mentioned this pull request May 19, 2021
Merged
@aanm aanm mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@michi-covalent michi-covalent Awaiting requested review from michi-covalent

Assignees

@michi-covalent michi-covalent

Labels
area/CI Continuous Integration testing issue or flake gsoc Potential GSoC project or pull request related to GSoC ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e tests for fromEntities policies
9 participants
@chez-shanpu @nathanjsweet @jrajahalme @pchaigno @michi-covalent @vadorovsky @twpayne @aanm @qmonnet