node-neigh: Query once netlink for neigh discovery device #15431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit calls netlink.LinkByName only once to retrieve a netdev used for arpinging neighbors. We can optimize this, because the configuration of cilium does not change during runtime. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
area/daemon
|
test-me-please |
|
test-net-next |
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.16
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Needs backport from master
in 1.7.16
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.6
This was referenced Apr 1, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.9
|
Removing the 1.7 backport label, as we don't do the periodic ARP refresh in 1.7. |
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.6
This was referenced Apr 20, 2021
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit calls
netlink.LinkByName()only once to retrieve a netdev used for arpinging neighbors. We can optimize this, because the configuration of cilium does not change during runtime.