vendor: Bump to latest vishvananda/netlink #15461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the upstreamed version of the encryption fixes we were previously carrying in a Cilium library fork of the upstream library. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
area/encryption
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
joestringer
commented
Mar 25, 2021
| @@ -248,6 +248,7 @@ func parseXfrmPolicy(m []byte, family int) (*XfrmPolicy, error) { | |||
| resTmpl.Mode = Mode(tmpl.Mode) | |||
| resTmpl.Spi = int(nl.Swap32(tmpl.XfrmId.Spi)) | |||
| resTmpl.Reqid = int(tmpl.Reqid) | |||
| resTmpl.Optional = int(tmpl.Optional) | |||
There was a problem hiding this comment.
This is the only practical difference from the encryption side. Basically when deserializing kernel objects, we will read the new field back out. I don't think we were relying on this side of things. /cc @jrfastab
pchaigno
approved these changes
Mar 25, 2021
|
test-me-please |
kkourt
approved these changes
Mar 25, 2021
rolinh
approved these changes
Mar 25, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the upstreamed version of the encryption fixes we were
previously carrying in a Cilium library fork of the upstream library.
Should we backport this given that PR #15048 was backported to {1.8,1.9}?