Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "encryption: Limit encryption keys to 2 bits" #15487

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Revert "encryption: Limit encryption keys to 2 bits" #15487

merged 1 commit into from
Mar 30, 2021

Conversation

brb
Copy link
Member

@brb brb commented Mar 27, 2021 •
edited

This revert fixes the failing CI on 4.9 (Transparent encryption DirectRouting Check connectivity with transparent encryption and direct routing*). Let's revert until the PR has been fixed.

@maintainer-s-little-helper

This comment has been minimized.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 27, 2021
@brb
Copy link
Member Author

brb commented Mar 27, 2021

test-4.9

@brb brb mentioned this pull request Mar 27, 2021
Merged
@brb brb force-pushed the pr/brb/flake-enc-with-droutes branch from 8a31218 to 7416632 Compare March 29, 2021 09:23
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 29, 2021
@brb brb added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Mar 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 29, 2021
@brb brb marked this pull request as ready for review March 29, 2021 09:24
@brb brb requested a review from a team March 29, 2021 09:24
@brb brb requested review from a team as code owners March 29, 2021 09:24
@brb
Copy link
Member Author

brb commented Mar 29, 2021

test-me-please

@pchaigno pchaigno mentioned this pull request Mar 29, 2021
Merged
borkmann
borkmann approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a better commit message? It would be unclear from the git log itself to get a rationale on why it was needed to be reverted.

@pchaigno pchaigno mentioned this pull request Mar 29, 2021
Merged
@brb
Revert "encryption: Limit encryption keys to 2 bits"
b2a28f7 
This reverts commit 1bc7172.

The commit breaks the CI on 4.9 ("Transparent encryption DirectRouting
Check connectivity with transparent encryption and direct routing*),
therefore we revert until the commit has been properly fixed.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/flake-enc-with-droutes branch from 7416632 to b2a28f7 Compare March 30, 2021 07:57
@brb
Copy link
Member Author

brb commented Mar 30, 2021

@borkmann Thanks, I've extended the git commit msg.

@brb
Copy link
Member Author

brb commented Mar 30, 2021

test-me-please

@nebril
Copy link
Member

nebril commented Mar 30, 2021

test-runtime

@nebril
Copy link
Member

nebril commented Mar 30, 2021

test-1.13-netnext

@nebril
Copy link
Member

nebril commented Mar 30, 2021

test-1.19-4.19

@nebril
Copy link
Member

nebril commented Mar 30, 2021

test-1.20-4.9

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Mar 30, 2021
@aanm
Copy link
Member

aanm commented Mar 30, 2021

merging as this fixes the regressions

@aanm aanm merged commit cdbb0d1 into master Mar 30, 2021
1.10.0 automation moved this from In progress to Done Mar 30, 2021
@aanm aanm deleted the pr/brb/flake-enc-with-droutes branch March 30, 2021 23:20
@aanm aanm mentioned this pull request Mar 31, 2021
Merged
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

@michi-covalent michi-covalent Awaiting requested review from michi-covalent

@joestringer joestringer Awaiting requested review from joestringer

Assignees

@borkmann borkmann

@joestringer joestringer

@michi-covalent michi-covalent

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@brb @nebril @aanm @borkmann @pchaigno @joestringer @michi-covalent