Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add BGP GSG #15519

Merged
merged 1 commit into from
Apr 20, 2021
Merged

docs: Add BGP GSG #15519

merged 1 commit into from
Apr 20, 2021

Conversation

christarazi
Copy link
Member

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi christarazi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/loadbalancing sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact. labels Mar 31, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 31, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 31, 2021
@christarazi christarazi mentioned this pull request Mar 31, 2021
Merged
5 tasks
@christarazi christarazi marked this pull request as ready for review April 14, 2021 17:40
@christarazi christarazi requested a review from a team as a code owner April 14, 2021 17:40
@christarazi christarazi requested review from a team and errordeveloper and removed request for a team April 14, 2021 17:40
qmonnet
qmonnet requested changes Apr 14, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting nits: Could you please make sure you use the same level of indentation for all your blocks? Ideally left-align on the name of the directive (code-block), like you did for the parsed-literal with 3 spaces.

Looks all good otherwise.

Documentation/gettingstarted/bgp.rst Outdated Show resolved Hide resolved
@christarazi
docs: Add BGP GSG
819df2c 
Signed-off-by: Chris Tarazi <chris@isovalent.com>
errordeveloper
errordeveloper reviewed Apr 15, 2021
View reviewed changes
Documentation/gettingstarted/bgp.rst
spec:
containers:
- name: web
image: nginx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like nginx is only used as example app in other page, do we have a demo app that is good for this? If not, I think podinfo could be a good candidate. Just a thought, and I guess here it doesn't matter all that much as we are not doing blue/green deployments or anything like that, but may a simple app that has Cilium logo would be nice.

errordeveloper
errordeveloper approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, just added a comment with some thoughts regarding the demo app.

@aanm aanm added this to the 1.10.0-rc.1 milestone Apr 16, 2021
@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 19, 2021
@pchaigno pchaigno merged commit d0a15fb into cilium:master Apr 20, 2021
1.10.0 automation moved this from In progress to Done Apr 20, 2021
@christarazi christarazi deleted the pr/christarazi/bgp-gsg-docs branch April 20, 2021 16:38
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
No open projects
1.10.0
Done
Milestone
1.10.0-rc.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@christarazi @errordeveloper @qmonnet @pchaigno @aanm