loader : Log upsert and remove route errors #15525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes : cilium#15282 Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
test-me-please |
pchaigno
approved these changes
Apr 6, 2021
|
test-1.20-4.19 Previously failed with https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.19/11/testReport/junit/Suite-k8s-1/20/K8sServicesTest_Checks_service_across_nodes_Tests_NodePort_BPF_Tests_with_vxlan_Tests_NodePort_with_sessionAffinity/. Likely a flake. |
pchaigno
added
the
ready-to-merge
|
I opened #15572 for the new flake. Merging. |
joestringer
reviewed
Apr 7, 2021
| if ep.RequireEndpointRoute() { | ||
| upsertEndpointRoute(ep, *ip.IPNet(32)) | ||
| if err := upsertEndpointRoute(ep, *ip.IPNet(32)); err != nil { | ||
| scopedLog.WithError(err).Warn("Failed to upsert route") |
There was a problem hiding this comment.
Does this log message contain the actual route which could not be added/removed? That would be super helpful details to have when these cases are hit.
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #15282
Signed-off-by: Gaurav Genani h3llix.pvt@gmail.com