Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove nop condition from tests #15541

Merged
merged 1 commit into from
Apr 3, 2021
Merged

test: Remove nop condition from tests #15541

merged 1 commit into from
Apr 3, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Apr 1, 2021

RunsWithKubeProxy || RunsWithoutKubeProxy is of course always true.

@pchaigno
test: Remove nop condition from tests
3f6471e 
"RunsWithKubeProxy || RunsWithoutKubeProxy" is of course always true.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 1, 2021
@pchaigno pchaigno requested a review from a team as a code owner April 1, 2021 16:07
@pchaigno pchaigno requested a review from a team April 1, 2021 16:07
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 1, 2021
@pchaigno pchaigno assigned pchaigno and unassigned aditighag and michi-covalent Apr 1, 2021
@pchaigno pchaigno added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 1, 2021
@pchaigno pchaigno assigned aditighag and michi-covalent and unassigned pchaigno Apr 1, 2021
aditighag
aditighag approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@aditighag aditighag removed their assignment Apr 1, 2021
@vadorovsky vadorovsky merged commit 80bbe9e into cilium:master Apr 3, 2021
1.10.0 automation moved this from In progress to Done Apr 3, 2021
@pchaigno pchaigno deleted the remove-nop-condition-from-tests branch April 3, 2021 13:53
@joestringer joestringer mentioned this pull request Apr 28, 2021
Closed
@joestringer joestringer mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

@michi-covalent michi-covalent Awaiting requested review from michi-covalent

Assignees

@michi-covalent michi-covalent

Labels
area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchaigno @aditighag @vadorovsky @michi-covalent