Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireguard: Fix rp_filter setting #15542

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

brb
Copy link
Member

@brb brb commented Apr 1, 2021

We need it only when IPv4 is enabled.

Fixes: 3bb9086 ("wireguard: Add agent code")

@brb brb added kind/bug This is a bug in the Cilium logic. area/daemon Impacts operation of the Cilium daemon. labels Apr 1, 2021
@brb brb requested a review from gandro April 1, 2021 16:12
@brb brb requested a review from a team as a code owner April 1, 2021 16:12
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 1, 2021
We need it only when IPv4 is enabled.

Fixes: 3bb9086 ("wireguard: Add agent code")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added release-note/misc This PR makes changes that have no direct user impact. and removed kind/bug This is a bug in the Cilium logic. labels Apr 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 1, 2021
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 1, 2021
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to re-run conformance tests. I will merge once they pass.

@vadorovsky vadorovsky merged commit 17aa113 into master Apr 1, 2021
@vadorovsky vadorovsky deleted the pr/brb/fix-rp-filter-wg branch April 1, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon Impacts operation of the Cilium daemon. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants