logging: expose more syslog options #15545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
assigned twpayne, gandro and nebril and unassigned nebril
jaffcheng
force-pushed
the
expose-more-syslog-options-upstream
branch
from
a0fa24c
to
dfdbf22
Compare
Expose more syslog options via --log-opt to make syslog more configurable.
Before this commit we can only log to the default facility `kern`
of localhost, which may pollute kernel log file.
Also, add a fatal out logic to cilium-agent, cilium-operator and cilium-health,
if an error is returned from SetupLogging.
The following option keys are added:
syslog.network
syslog.address
syslog.facility
syslog.severity
syslog.tag
configmap example for syslog driver: {"syslog.level":"info","syslog.facility":"local5","syslog.tag":"cilium-agent"}
Signed-off-by: Jaff Cheng <jaff.cheng.sh@gmail.com>
jaffcheng
force-pushed
the
expose-more-syslog-options-upstream
branch
from
dfdbf22
to
bdcdcd5
Compare
Runtime CI failed as I missed the newly added Alibaba operator cmdref, rebased and updated |
|
test-me-please |
nebril
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nebril
approved these changes
Apr 7, 2021
|
For some reason jenkins didn't report the status. I've check and all have passed, only one flake found #15572. Merging... |
|
(FYI, that flake is actually #15455.) |
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose more syslog options via --log-opt to make syslog more configurable.
Before this commit we can only log to the default facility
kernof localhost, which may pollute kernel log file.
Also, add a fatal out logic to cilium-agent, cilium-operator and cilium-health,
if an error is returned from SetupLogging.
The following option keys are added:
configmap example for syslog driver: {"syslog.level":"info","syslog.facility":"local5","syslog.tag":"cilium-agent"}
Signed-off-by: Jaff Cheng jaff.cheng.sh@gmail.com