hubble: Add a flag to write Hubble events to a rotated file #15557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
the
release-note/minor
glibsm
reviewed
Apr 5, 2021
|
fixing test failures... |
|
test-me-please |
|
test-gke |
|
test-1.16-netnext |
rolinh
approved these changes
Apr 6, 2021
tklauser
approved these changes
Apr 6, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
pchaigno
removed
the
ready-to-merge
|
thank you all for your review. addressed all the comments except for #15557 (comment) will add more test cases tomorrow 👍 |
|
added some more test cases |
|
test-me-please |
Add a flag to write Hubble events from OnDecodeEvent() to a rotated file. It could be useful for troubleshooting to have access to recent events beyond what's kept in memory. Use it with caution as it can add significant overhead on busy nodes. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
|
test-me-please |
|
I checked that all team review requests are covered. Tests are passing. Merging. |
pchaigno
added
the
ready-to-merge
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to write Hubble events from OnDecodeEvent() to a rotated
file. It could be useful for troubleshooting to have access to recent
events beyond what's kept in memory. Use it with caution as it can
add significant overhead on busy nodes.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com