daemon: Remove --help flags grouping #15564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
brb
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
borkmann
approved these changes
Apr 6, 2021
brb
force-pushed
the
pr/brb/rm-help-flags-grouping
branch
from
0710419
to
7603ac6
Compare
|
test-me-please |
twpayne
approved these changes
Apr 6, 2021
aanm
approved these changes
Apr 6, 2021
pchaigno
added
the
dont-merge/needs-rebase
brb
force-pushed
the
pr/brb/rm-help-flags-grouping
branch
from
7603ac6
to
5210f1a
Compare
brb
removed
the
dont-merge/needs-rebase
This commit reverts the --help flags grouping introduced by [1]. The motivation for removing the grouping is the following: - Some flags should be in multiple groups to help users to navigate through the flags (e.g. "IPMasqAgentConfigPath"). - Some grouping doesn't make much sense (e.g. "IP flags" - each flag should belong to a different group instead). - We tend to forget to add new flags. Therefore considering above, the alphabetical order yields better UX. [1]: #10795 Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-me-please |
brb
added
the
ready-to-merge
|
k8s-1.20-kernel-4.19 failed with known flake #15575. Other CI jobs are passing (even though GitHub doesn't report the updated status). |
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts the --help flags grouping introduced by [1].
The motivation for removing the grouping is the following:
through the flags (e.g. "IPMasqAgentConfigPath").
should belong to a different group instead).
Therefore considering above, the alphabetical order yields better UX.
[1]: #10795