examples: Split host policies for dev. VMs #15577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current extensive host policy for the development VMs (implements the most restrictive policy possible) was written to support both values of enable-remote-node-identity. When that flag is enabled, rules for the remote node are implemented with the remote-node entity; when it is disabled, the node CIDR is used. Unfortunately, when enable-remote-node-identity is given, the policy is not the most restrictive possible anymore, because we now have additional rules matching on node CIDR. To ensure we have the most restrictive policy possible, we need to split the existing host policy into two policies, for each value of the flag. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
release-note/misc
4 tasks
joestringer
reviewed
Apr 6, 2021
There was a problem hiding this comment.
I'm not sure I understand why the policy is not minimal if enable-remote-node-identity=false. Presumably in that case the extra rules are no-ops because the remote-node identity is not used for determining policy posture. When it's enabled, then it looks like the new policy file is just the same as what the current policy is. Am I missing something?
joestringer
approved these changes
Apr 6, 2021
Exactly. |
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current extensive host policy for the development VMs (implements the most restrictive policy possible) was written to support both values of
enable-remote-node-identity. When that flag is enabled, rules for the remote node are implemented with theremote-nodeentity; when it is disabled, the node CIDR is used.Unfortunately, when
enable-remote-node-identityis given, the policy is not the most restrictive possible anymore, because we now have additional rules matching on node CIDR. To ensure we have the most restrictive policy possible, we need to split the existing host policy into two policies, for each value of the flag.These files are not tested anywhere and only used for local testing, so no need to run the full CI.