Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/proxy.h: set variable as maybe unused to avoid compilation error #15607

Merged
merged 1 commit into from
Apr 27, 2021
Merged

lib/proxy.h: set variable as maybe unused to avoid compilation error #15607

merged 1 commit into from
Apr 27, 2021

Conversation

chkhalt
Copy link

@chkhalt chkhalt commented Apr 8, 2021

Set variable as __maybe_unused and define the macro HOST_REDIRECT_TO_INGRESS in the Makefile.

Fixes: #15095
Fixes: #15559

Signed-off-by: Joao Victorino joao@accuknox.com

lib/proxy.h: set variable as maybe unused to avoid compilation error
0856621 
This allow us to have HOST_REDIRECT_TO_INGRESS defined without a compilation error.
As the code in #15560 is already merged, we define the macro in the Makefile.

Fixes: #15095
Fixes: #15559

Signed-off-by: Joao Victorino <joao@accuknox.com>
@chkhalt chkhalt marked this pull request as ready for review April 8, 2021 12:11
@chkhalt chkhalt requested a review from a team April 8, 2021 12:11
@chkhalt chkhalt requested a review from a team as a code owner April 8, 2021 12:11
@pchaigno pchaigno added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loader Impacts the loading of BPF programs into the kernel. labels Apr 8, 2021
@pchaigno pchaigno self-requested a review April 8, 2021 13:01
@pchaigno pchaigno removed their assignment Apr 8, 2021
@pchaigno
Copy link
Member

pchaigno commented Apr 21, 2021 •
edited

Restarting these as we waiting too long to triage and lost the artifacts :-(

test-runtime

@pchaigno
Copy link
Member

test-1.21-4.9

@pchaigno
Copy link
Member

test-1.16-netnext

@chkhalt chkhalt mentioned this pull request Apr 23, 2021
Closed
@chkhalt
Copy link
Author

chkhalt commented Apr 23, 2021

@pchaigno, any ideas why 1.16 and 1.21 have failed?

@pchaigno
Copy link
Member

pchaigno commented Apr 23, 2021 •
edited

k8s-1.16-kernel-netnext failed because of (1) a case of #15474 on the WireGuard test and (2) known flake #15620. However, https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/274/testReport/junit/Suite-k8s-1/21/K8sPolicyTest_Basic_Test_checks_all_kind_of_Kubernetes_policies/ is currently unknown as a flake, so restarting to confirm:

test-1.21-4.9

If it doesn't fail again, we'll have to open an issue to track it.

@aanm aanm merged commit 652ccd2 into cilium:master Apr 27, 2021
@aanm
Copy link
Member

aanm commented Apr 27, 2021

@pchaigno I didn't fully understand your last message.

This was referenced Apr 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@joestringer joestringer joestringer approved these changes

@jrfastab jrfastab jrfastab approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees

@jrfastab jrfastab

Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Milestone
No milestone
6 participants
@chkhalt @pchaigno @aanm @borkmann @joestringer @jrfastab