pkg/k8s: set the right api group for EndpointSlice #15631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If EndpointSlice V1 is enabled we should set it correctly in the `cilium status` output. Fixes: 5ee4c6f ("add support for EndpointSlice V1") Signed-off-by: André Martins <andre@cilium.io>
aanm
added
the
sig/k8s
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
test-me-please |
christarazi
approved these changes
Apr 10, 2021
|
The CI failed with a known bug but at least we don't see the EndpointSlice v1beta1 mention anymore: |
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If EndpointSlice V1 is enabled we should set it correctly in the
cilium statusoutput.Fixes: 5ee4c6f ("add support for EndpointSlice V1")
Signed-off-by: André Martins andre@cilium.io
Fixes #15594
@joestringer I'm marking it as fixed just to close the GH issue since I can't replicate it on my side. I did notice this bug in the sysdump. In case we see the #15594 again, we can re-open it and check if the cilium status has the correct API or not.