docs: Add section for filtering by subnet tags in ENI mode #15635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
area/eni
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
requested changes
Apr 12, 2021
| Create a `cni-config.yaml` file based on the template below. Fill in the | ||
| ``subnet-tags`` field: | ||
|
|
||
| .. code:: yaml |
There was a problem hiding this comment.
I think these all need to be code-block, code is rST while code-block is sphinx syntax which allows the sphinx-specific syntax highlighting to work correctly.
Suggested change
| .. code:: yaml | |
| .. code-block:: yaml |
christarazi
force-pushed
the
pr/christarazi/update-eks-subnet-tags-docs
branch
2 times, most recently
from
45093dc
to
3e7a74d
Compare
Users frequently ask how to properly filter subnets by tag in ENI mode. This commit adds a dedicated section to the AWS ENI guide on just that. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/update-eks-subnet-tags-docs
branch
from
3e7a74d
to
b4e6ce6
Compare
joestringer
approved these changes
Apr 13, 2021
tgraf
approved these changes
Apr 15, 2021
|
Marking ready for merge, as we have approvals and the docs build passed. |
christarazi
added
the
ready-to-merge
|
Usually we would backport docs fixes like this, but apparently the v1.9 chart doesn't support eni sub-options so we would also need to address that if we were to backport this PR. |
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users frequently ask how to properly filter subnets by tag in ENI mode.
This commit adds a dedicated section to the AWS ENI guide on just that.
Signed-off-by: Chris Tarazi chris@isovalent.com