-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add Egress Gateway Getting Started Guide #15661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I find the steps very clear and well-explained. I have a few comments on the formatting below.
Please also address the issues reporting from the CI:
- A few typo (also highlighted in my review)
- You need to reference your documents from an index. From the list of the Getting Started Guides for example, likely in the Advanced Networking section.
Please also make sure that you use consistent levels of indents for all the directives in your document (block-content should ideally be left-aligned on the first letter of the directive name, as is the case for your first parsed-literal block for example).
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! There are still a few items remaining, please see the un-resolved items above. In addition, you still need to link the document somewhere, and to add busybox
to the list of correct words as suggested by the failing GitHub action:
Please fix the following documentation warnings:
/github/workspace/Documentation/gettingstarted/egress-gateway.rst: WARNING: document isn't included in any toctree
Please fix the following spelling mistakes:
* Documentation/gettingstarted/egress-gateway.rst:127: (busybox)
If the words are not misspelled, run:
Documentation/update-spelling_wordlist.sh busybox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the couple build issues mentioned by Quentin to be able to render locally and review. I haven't tested yet, but I think it needs a couple changes if we want folks to be able to follow the guide (without needing to deploy our development VM).
- name: EGRESS_IPS | ||
value: "192.168.33.100/24 192.168.33.101/24" | ||
args: | ||
- "for i in $EGRESS_IPS; do ip address add $i dev enp0s8; done; sleep 10000000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be enough for users running in e.g. GKE, EKS, AKS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the guide for onprem environment. In cloud, the way to assign IP addresses will be very different in different cloud providers. We haven't covered those environments yet. Maybe we could do it as next step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be enough to use the existing node IP for managed Kubernetes? It won't demonstrate the SNAT part of the egress gateway, but at least users would be able to observe the redirect. I guess it's better than nothing.
If that's not an option, we should at least clarify at the top that the guide doesn't currently support managed Kubernetes. I would be very careful how we word this though; we don't want to give the impression the feature doesn't support managed Kubernetes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. I'll try in on GKE first as an example. But I won't be able to cover other platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I won't be able to cover other platforms.
I think that's fine as long as we don't make the guide GKE-specific in some way. If there are small issues when running it on other managed K8s, we can always fix them up later.
7fbde50
to
689e46e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. Thanks for the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question for potential simplification only.
This is a documentation of the detailed instructions on configuring cilium components to start using the egress nat gateway feature. RFE: cilium#13575 Signed-off-by: Yongkun Gui <ygui@google.com> Signed-off-by: Bolun Zhao <blzhao@google.com>
test-me-please |
1 similar comment
test-me-please |
@anfernee This isn't needed for documentation-only changes. There's already |
This is a documentation of the detailed instructions on configuring
cilium components to start using the egress nat gateway feature.
RFE: #13575
Signed-off-by: Yongkun Gui ygui@google.com
Signed-off-by: Bolun Zhao blzhao@google.com