cilium: Use build-and-push-with-qemu for builder #15679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix images-legacy.yaml to use build-and-push-with-qemu. Fixes: 044afab ("ci: Set up qemu in images workflow and build cilium-test") Signed-off-by: John Fastabend <john.fastabend@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Given that master is currently broken with the following message and this aligns the job requirement with the job introduced in the commit being fixed here, this LGTM and I will merge without waiting for CI to pass.
The workflow is not valid. Job image-digests depends on unknown job build-and-push-cilium-test.
https://github.com/cilium/cilium/actions/runs/745914737
joestringer
added
release-note/misc
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix images-legacy.yaml to use build-and-push-with-qemu.
Fixes: 044afab ("ci: Set up qemu in images workflow and build cilium-test")
Signed-off-by: John Fastabend john.fastabend@gmail.com