source: Reorder AllowSource switch Statement and Comment Nits #15696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AllowSource method contains logic that maps the hierarchical sources of truth for when an entity's existing source allows a new source of truth to overwrite it. The method was written so that the cases were not in the order of their importance, which makes the method confusing to read. Additionally there were some typos and incorrectly worded comments that further make the method difficult to read. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
nathanjsweet
added
area/misc
aanm
approved these changes
Apr 14, 2021
joestringer
approved these changes
Apr 14, 2021
|
test-me-please |
qmonnet
approved these changes
Apr 14, 2021
|
test-runtime |
|
The previous occurrence failed because of a short build breakage on master, fixed since then. test-runtime |
|
A couple tests failed in 1.21-4.9. Let's see if they are flakes. If they are, we need to open issues. test-1.21-4.9 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
christarazi
approved these changes
Apr 20, 2021
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AllowSource method contains logic that maps the
hierarchical sources of truth for when an entity's existing
source allows a new source of truth to overwrite it.
The method was written so that the cases were not in the order
of their importance, which makes the method confusing to read.
Additionally there were some typos and incorrectly worded comments
that further make the method difficult to read.
Signed-off-by: Nate Sweet nathanjsweet@pm.me