daemon/ipam: correct total IP count in cilium status output
#15707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://github.com/cilium/ipam/blob/master/service/ipallocator/allocator.go#L61 Currently two (the base and broadcast) IPs are excluded from IPAM when using hostscope mode (see above link), but the status output only excludes one. Signed-off-by: ArthurChiao <arthurchiao@hotmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
qmonnet
approved these changes
Apr 15, 2021
qmonnet
requested review from
a team and
twpayne
and removed request for
a team
qmonnet
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
test-me-please |
twpayne
approved these changes
Apr 15, 2021
|
test-gke |
|
test-runtime |
test-runtime |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/cilium/ipam/blob/master/service/ipallocator/allocator.go#L61
Currently two (the base and broadcast) IPs are excluded from IPAM when
using hostscope mode (see above link), but the status output only excludes one.
Signed-off-by: ArthurChiao arthurchiao@hotmail.com