Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add multicluster CI 3.0 workflow #15710

Merged
merged 1 commit into from
Apr 20, 2021
Merged

workflows: add multicluster CI 3.0 workflow #15710

merged 1 commit into from
Apr 20, 2021

Conversation

nbusseneau
Copy link
Member

This was ported and adapted from cilium-cli as part the CI 3.0 initiative.

@nbusseneau nbusseneau added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Apr 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 15, 2021
@nbusseneau nbusseneau requested a review from nebril April 15, 2021 13:23
@nbusseneau
Copy link
Member Author

nbusseneau commented Apr 15, 2021

Test run for this workflow here: https://github.com/cilium/cilium/actions/runs/752276326

@nbusseneau
Copy link
Member Author

Alright so we have pod-to-pod and pod-to-service failing:

❌ 2/7 tests failed (0 warnings)

Failed tests: ❌ pod-to-pod: cilium-test/client-6c46bff775-d5s7k -> cilium-test/echo-other-node-86774f89b9-dsvds, ❌ pod-to-service: cilium-test/client-6c46bff775-d5s7k -> echo-other-node:8080 (ClusterIP), ✅ pod-to-service: cilium-test/client-6c46bff775-d5s7k -> echo-same-node:8080 (ClusterIP), ✅ pod-to-world: cilium-test/client-6c46bff775-d5s7k -> https://google.com, ✅ pod-to-host: cilium-test/client-6c46bff775-d5s7k -> 10.168.0.30, ✅ pod-to-host: cilium-test/client-6c46bff775-d5s7k -> 10.168.0.33, ✅ pod-to-pod: cilium-test/client-6c46bff775-d5s7k -> cilium-test/echo-same-node-f789dd8f7-4mqml

However this is the same as in cilium-cli repo: https://github.com/cilium/cilium-cli/actions/runs/631421886
This has been broken since 2~3 months 😅

Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one non-blocking comment.

.github/workflows/multicluster.yaml Show resolved Hide resolved
@nbusseneau
Copy link
Member Author

nbusseneau commented Apr 16, 2021

No idea why but this run was successful: https://github.com/cilium/cilium/actions/runs/756782113
Is it a flake? Will re-run to see. EDIT: still working 🎉 https://github.com/cilium/cilium/actions/runs/756897245
Only difference I think had a potential impact was switching to COS_CONTAINERD image type.

@nbusseneau nbusseneau marked this pull request as ready for review April 16, 2021 21:10
@nbusseneau nbusseneau requested review from a team as code owners April 16, 2021 21:10
.github/workflows/multicluster.yaml Outdated Show resolved Hide resolved
This was ported and adapted from `cilium-cli` as part the CI 3.0
initiative.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau
Copy link
Member Author

nbusseneau commented Apr 19, 2021

Marking as ready to merge as Maciej actually already validated on behalf of ci-structure, he just did it before I switched the PR out of draft and ci-structure was added.

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 19, 2021
@pchaigno pchaigno merged commit 68ce87c into cilium:master Apr 20, 2021
1.10.0 automation moved this from In progress to Done Apr 20, 2021
@nbusseneau nbusseneau deleted the pr/multicluster-workflow branch April 20, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants