Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS deps #15759

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Update AWS deps #15759

merged 1 commit into from
Apr 20, 2021

Conversation

ungureanuvladvictor
Copy link
Member

Signed-off-by: Vlad Ungureanu ungureanuvladvictor@gmail.com

@ungureanuvladvictor ungureanuvladvictor added area/operator Impacts the cilium-operator component release-note/misc This PR makes changes that have no direct user impact. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Apr 18, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 18, 2021
@ungureanuvladvictor
Update AWS deps
7d695f1 
Signed-off-by: Vlad Ungureanu <ungureanuvladvictor@gmail.com>
@ungureanuvladvictor
Copy link
Member Author

ci-eks -- checking if this works!

@ungureanuvladvictor
Copy link
Member Author

test-me-please

@ungureanuvladvictor ungureanuvladvictor marked this pull request as ready for review April 18, 2021 18:10
@ungureanuvladvictor ungureanuvladvictor requested a review from a team as a code owner April 18, 2021 18:10
@ungureanuvladvictor ungureanuvladvictor mentioned this pull request Apr 18, 2021
Open
@ungureanuvladvictor
Copy link
Member Author

test-gke

@ungureanuvladvictor
Copy link
Member Author

test-1.16-netnext

@ungureanuvladvictor
Copy link
Member Author

retest-net-next

christarazi
christarazi approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you happen to know, would these changes support IMDSv2 API (context: #15520)?

@ungureanuvladvictor
Copy link
Member Author

@christarazi I see aws/aws-sdk-go-v2#453 and that was included in config/v0.1.0. I think the SDK by default tries to use imdsv2 if it is not disabled. Will have to look at bit more at this to be 100% sure.

@ungureanuvladvictor
Copy link
Member Author

test-gke

@ungureanuvladvictor
Copy link
Member Author

test-1.16-netnext

@aanm aanm merged commit 15e4954 into master Apr 20, 2021
1.10.0 automation moved this from In progress to Done Apr 20, 2021
@aanm aanm deleted the vladu/update-aws-deps branch April 20, 2021 20:07
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@christarazi christarazi christarazi approved these changes

@rolinh rolinh Awaiting requested review from rolinh

Assignees

@rolinh rolinh

Labels
area/operator Impacts the cilium-operator component integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ungureanuvladvictor @tklauser @christarazi @rolinh @aanm