daemon: Remove unnecessary log #15776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This log msg is unnecessary and was added in 25a90dc ("daemon: log errors from bpf.TestDummyProg()"). It is unnecessary because the option it is warning about is not even exposed to the user, so it is completely irrelevant and un-actionable. Fixes: cilium#15727 Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
area/daemon
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
Apr 19, 2021
brb
approved these changes
Apr 20, 2021
aanm
approved these changes
Apr 20, 2021
| @@ -231,13 +231,11 @@ func initKubeProxyReplacementOptions() (strict bool) { | |||
| option.Config.EnableHostServicesPeer = true | |||
| if option.Config.EnableIPv4 { | |||
| if err := bpf.TestDummyProg(bpf.ProgTypeCgroupSockAddr, bpf.BPF_CGROUP_INET4_GETPEERNAME); err != nil { | |||
| log.WithError(err).Warn("Disabling HostServicesPeer feature.") | |||
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log msg is unnecessary and was added in 25a90dc ("daemon: log
errors from bpf.TestDummyProg()"). It is unnecessary because the option
it is warning about is not even exposed to the user, so it is completely
irrelevant and un-actionable.
Fixes: #15727
Signed-off-by: Chris Tarazi chris@isovalent.com