daemon: Make Hubble Recorder API opt-out #15781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
gandro
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
borkmann
approved these changes
Apr 20, 2021
|
I don't think this needs a full CI run (as none of the Recorder functionality is currently tested in CI). I have manually tested that it works as expected. If disabled, theHubble CLI will fail with |
This commits switches the default value of `--enable-hubble-recorder-api` to `true`. It is important to note that this change does _not_ mean that the recorder API itself is always enabled by default. For the Hubble Recorder API to actually be served, both `--enable-hubble` and `--enable-recorder` also need to be enabled (both of which are `false` by default). Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/hubble-recorder-api-flag-default
branch
from
97c9a13
to
36c9ba2
Compare
borkmann
added
release-blocker/1.10
feature/lb-only
gandro
added
the
ready-to-merge
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits switches the default value of
--enable-hubble-recorder-apitotrue. It is important to note thatthis change does not mean that the recorder API itself is always
enabled by default. For the Hubble Recorder API to actually be served,
both
--enable-hubbleand--enable-recorderalso need to be enabled(both of which are
falseby default).Previous discussion: #15680 (comment)