k8s: Fix Wireguard with IPAM != ClusterPool #15784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a leftover if-condition from earlier versions of wireguard in Cilium where it needed to wait for the operator to allocate a Wireguard tunnel IP (see cilium#15565 for details). This fixes a bug where Cilium agent would indefinitely wait for K8s node information when using Wireguard in combination with an IPAM mode other than ClusterPool. Fixes: 0ecab37 ("wireguard: Remove operator") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
kind/bug
gandro
changed the title
|
test-me-please |
pchaigno
approved these changes
Apr 20, 2021
pchaigno
added
the
area/encryption
brb
approved these changes
Apr 20, 2021
aanm
approved these changes
Apr 20, 2021
|
Marking as ready-to-merge. The quick-install pipeline will never run, since this branch is already based on #15695 which removed them. |
gandro
added
the
ready-to-merge
|
ConformanceGKE failed with known flake #15619 and isn't required anyway. Other jobs are passing. All reviews are in. Merging. |
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a leftover if-condition from earlier versions of Wireguard
in Cilium where it needed to wait for the operator to allocate a
Wireguard tunnel IP (see #15565 for details). With the removal of
the operator logic, if-statement is not needed anymore for Wireguard
and is breaking other IPAM modes.
This fixes a bug where Cilium agent would indefinitely wait for K8s node
information when using Wireguard in combination with an IPAM mode other
than ClusterPool.
Fixes: 0ecab37 ("wireguard: Remove operator")