Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy flannel integration #15786

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 20, 2021

The old flannel integration is not really being used. Chaining on top of
flannel is also possible with the generic-veth chaining method.
Deprecate the legacy flannel integration and use the standard
generic-veth chaining instead.

@tgraf tgraf added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 20, 2021
@tgraf tgraf requested review from a team April 20, 2021 15:18
@tgraf tgraf requested review from a team as code owners April 20, 2021 15:19
@tgraf tgraf requested a review from a team April 20, 2021 15:19
@tgraf tgraf requested review from a team as code owners April 20, 2021 15:19
@tgraf tgraf requested a review from a team April 20, 2021 15:19
@tgraf tgraf requested a review from a team as a code owner April 20, 2021 15:19
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 20, 2021
@tgraf tgraf requested a review from gandro April 20, 2021 15:19
@tgraf tgraf requested review from kaworu and brb April 20, 2021 15:19
@tgraf tgraf marked this pull request as draft April 20, 2021 16:44
@brb
Copy link
Member

brb commented Apr 21, 2021

Oh wow, this will close many issues 🥳

The old flannel integration is not really being used. Chaining on top of
flannel is also possible with the generic-veth chaining method.
Deprecate the legacy flannel integration and use the standard
generic-veth chaining instead.

Signed-off-by: Thomas Graf <thomas@cilium.io>
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm related changes LGTM. Seems to me that the PR is technically more a removal rather than deprecation. If correct, I think the release-note should make it clear.

@tgraf tgraf changed the title Deprecate legacy flannel integration Remove legacy flannel integration Apr 23, 2021
@tgraf tgraf marked this pull request as ready for review April 23, 2021 11:52
@tgraf
Copy link
Member Author

tgraf commented Apr 23, 2021

test-me-please

@pchaigno
Copy link
Member

pchaigno commented Apr 26, 2021

test-gke

Other test failures are due to #15474: Jenkins runs with #15714 but not #15780 so the tests fail.

@joestringer joestringer added this to the 1.10.0-rc.1 milestone Apr 26, 2021
@joestringer
Copy link
Member

Jenkins-based GKE runs are currently broken due to infrastructure issue. CI 3.0 GKE was successful. We'll get plenty of subsequent testing as we branch for v1.10.0-rc1 so not too worried about bypassing this failure to merge. The other failures are linked to lack of rebase per @pchaigno's comment above.

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet