-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy flannel integration #15786
Conversation
4938ff6
to
4dcc5a4
Compare
Oh wow, this will close many issues 🥳 |
The old flannel integration is not really being used. Chaining on top of flannel is also possible with the generic-veth chaining method. Deprecate the legacy flannel integration and use the standard generic-veth chaining instead. Signed-off-by: Thomas Graf <thomas@cilium.io>
4dcc5a4
to
020c1ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helm related changes LGTM. Seems to me that the PR is technically more a removal rather than deprecation. If correct, I think the release-note should make it clear.
test-me-please |
Jenkins-based GKE runs are currently broken due to infrastructure issue. CI 3.0 GKE was successful. We'll get plenty of subsequent testing as we branch for v1.10.0-rc1 so not too worried about bypassing this failure to merge. The other failures are linked to lack of rebase per @pchaigno's comment above. Merging. |
The old flannel integration is not really being used. Chaining on top of
flannel is also possible with the generic-veth chaining method.
Deprecate the legacy flannel integration and use the standard
generic-veth chaining instead.