Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: fix GKE if condition #15788

Merged
merged 1 commit into from
Apr 20, 2021
Merged

workflows: fix GKE if condition #15788

merged 1 commit into from
Apr 20, 2021

Conversation

nbusseneau
Copy link
Member

For consistency with other workflows, and also in case it might actually be the reason GKE workflows are triggered on every comment instead of only for specific trigger phrases.

@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Apr 20, 2021
@nbusseneau nbusseneau requested review from a team as code owners April 20, 2021 18:17
@maintainer-s-little-helper
Copy link

Commit 43eda0cb6b239d2c71f549b40cf40fc2d8feb770 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 20, 2021
@pchaigno pchaigno removed their assignment Apr 20, 2021
For consistency with other workflows, and also in case it might actually be the reason GKE workflows are triggered on every comment instead of only for specific trigger phrases.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau changed the title workflow: fix GKE if condition workflows: fix GKE if condition Apr 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 20, 2021
@aanm aanm merged commit 1092c5f into master Apr 20, 2021
1.10.0 automation moved this from In progress to Done Apr 20, 2021
@aanm aanm deleted the pr/fix-gke-workflow branch April 20, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants