Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cloud provider conformance tests every 6 hours #15796

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

michi-covalent
Copy link
Contributor

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@michi-covalent michi-covalent requested review from a team as code owners April 20, 2021 22:05
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 20, 2021
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Apr 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 20, 2021
@michi-covalent
Copy link
Contributor Author

What about the cluster-mesh one? https://github.com/cilium/cilium/blob/09c465e232072b5da13c88c8a11460981efbb575/.github/workflows/multicluster.yaml

ah yes i missed that one. updating...

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀

@michi-covalent
Copy link
Contributor Author

test-me-please

@pchaigno
Copy link
Member

All team reviews are covered and CI is green. Marking as ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 21, 2021
@tklauser tklauser removed their assignment Apr 21, 2021
@aanm aanm merged commit 3b0d4fb into master Apr 21, 2021
1.10.0 automation moved this from In progress to Done Apr 21, 2021
@aanm aanm deleted the pr/michi/conform branch April 21, 2021 10:45
@joestringer
Copy link
Member

@michi-covalent thanks again for the PR, as a quick reminder for future PRs, please ensure that you either update the release note in the description or remove this section as these end up in the final release notes for the upcoming release:

<!-- Enter the release note text here if needed or remove this section! -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants