Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireguard: Improve logging #15807

Merged
merged 2 commits into from
Apr 21, 2021
Merged

wireguard: Improve logging #15807

merged 2 commits into from
Apr 21, 2021

Conversation

brb
Copy link
Member

@brb brb commented Apr 21, 2021

See commit msgs.

@brb brb added release-note/misc This PR makes changes that have no direct user impact. release-blocker/1.10 labels Apr 21, 2021
@brb brb requested a review from gandro April 21, 2021 08:44
@brb brb requested review from a team as code owners April 21, 2021 08:44
@brb brb requested a review from twpayne April 21, 2021 08:44
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 21, 2021
pkg/wireguard/agent/agent.go Outdated Show resolved Hide resolved
@brb brb force-pushed the pr/brb/wg-logs branch 2 times, most recently from 92c7571 to 0361b9d Compare April 21, 2021 10:23
brb added 2 commits April 21, 2021 12:24
Otherwise, on standard deployments we will generate a lot of noise. For
debugging purpose we can always ask users to change the log level to
debug.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
This will help us to detect cases when IPCache events are lagging
behind, and thus the encryption is not properly enforced (observed on
CI).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@pchaigno
Copy link
Member

Reviews are in and the code is building. I don't think we need to run the full CI as it's only minor logging changes. Merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 21, 2021
@pchaigno pchaigno merged commit 1e26578 into master Apr 21, 2021
@pchaigno pchaigno deleted the pr/brb/wg-logs branch April 21, 2021 13:40
1.10.0 automation moved this from In progress to Done Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants