helm: consolidate IPSec and Wireguard encryption options #15809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibi
added
release-note/minor
maintainer-s-little-helper
bot
assigned aanm, brb, gandro and seanmwinn and unassigned aanm
gandro
approved these changes
Apr 21, 2021
jibi
force-pushed
the
pr/jibi/consolidate-encryption-helm
branch
from
f5ab456
to
829f291
Compare
gandro
approved these changes
Apr 21, 2021
jibi
force-pushed
the
pr/jibi/consolidate-encryption-helm
branch
from
829f291
to
ff183bd
Compare
gandro
requested changes
Apr 21, 2021
There was a problem hiding this comment.
Ah, good catch with the daemonset. I think you missed one though:
https://github.com/cilium/cilium/blob/ff183bdcb54526123f7fe60bbe3f35f784350ec8/install/kubernetes/cilium/templates/cilium-agent-daemonset.yaml#L329
jibi
force-pushed
the
pr/jibi/consolidate-encryption-helm
branch
from
ff183bd
to
1a67b22
Compare
brb
approved these changes
Apr 21, 2021
jibi
force-pushed
the
pr/jibi/consolidate-encryption-helm
branch
from
1a67b22
to
e1fac81
Compare
aanm
approved these changes
Apr 21, 2021
This commit introduces a new helm option, encryption.type, which can be used to specifies what method should be used for encryption (either ipsec or wireguard). The goal here is to add support for wireguard without introducing any breaking change in the helm charts. Fixes: #15483 Co-authored-by: Youssef Azrak <yazrak.tech@gmail.com> Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
This commit updates the Wireguard GSG to reflect the new Helm options introduced to enable it. Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
force-pushed
the
pr/jibi/consolidate-encryption-helm
branch
from
e1fac81
to
8fe34cf
Compare
maintainer-s-little-helper
bot
assigned nbusseneau and qmonnet and unassigned nbusseneau
|
Updated docs and fixed the |
qmonnet
approved these changes
Apr 21, 2021
|
test-me-please |
nbusseneau
reviewed
Apr 21, 2021
|
test-me-please |
nbusseneau
approved these changes
Apr 22, 2021
jibi
added
the
ready-to-merge
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new helm option, encryption.type, which can be
used to specifies what method should be used for encryption (either
ipsec or wireguard).
The goal here is to add support for wireguard without introducing any
breaking change in the helm charts.
Fixes: #15483