Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: squash common operator images in a single Dockerfile #15849

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 23, 2021

Signed-off-by: André Martins andre@cilium.io

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Apr 23, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 23, 2021
@aanm aanm force-pushed the pr/squash-operator-images branch from e08d834 to bec2cfa Compare April 23, 2021 23:28
@aanm aanm mentioned this pull request Apr 23, 2021
7 tasks
@aanm
Copy link
Member Author

aanm commented Apr 23, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented Apr 24, 2021

test-gke

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/squash-operator-images branch from bec2cfa to 0e7a328 Compare April 24, 2021 02:34
@aanm
Copy link
Member Author

aanm commented Apr 24, 2021

The PR had the following changes just to test the new images in this branch, and the tests were green as we can see in the screenshot [1]

diff --git a/.github/workflows/images-legacy.yaml b/.github/workflows/images-legacy.yaml
index aad779ceff..c416b8d0c0 100644
--- a/.github/workflows/images-legacy.yaml
+++ b/.github/workflows/images-legacy.yaml
@@ -9,7 +9,6 @@ on:
   push:
     branches:
       - master
-      - pr/squash-operator-images
 
 jobs:
   build-and-push-prs:

[1]

image

The failures presented by GH actions are now expected because it's running workflow from master and the Dockerfiles are being removed in this PR.

@aanm aanm marked this pull request as ready for review April 24, 2021 02:35
@aanm aanm requested review from a team as code owners April 24, 2021 02:35
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@aanm aanm merged commit 648f4f0 into master Apr 26, 2021
1.10.0 automation moved this from In progress to Done Apr 26, 2021
@aanm aanm deleted the pr/squash-operator-images branch April 26, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants