contrib/vagrant: Use CRDs instead of kvstore if K8S=1 #15913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
release-note/misc
aanm
requested changes
Apr 28, 2021
christarazi
approved these changes
Apr 29, 2021
|
Removing myself from the list of reviewers, as I don't use Vagrant. |
pchaigno
force-pushed
the
use-crds-in-dev-vms
branch
from
ec3264c
to
3935869
Compare
aanm
requested changes
May 7, 2021
We want the default development setup to match the Helm defaults as closely as possible, to facilitate onboarding of new contributors and ease the reproduction of issues, as described in [1]. Several options were changed with that in mind in [2] but the development VMs still use the kvstore by default instead of relying on CRDs. 1 - cilium#15364 2 - cilium#15367 Reported-by: Bolun Zhao <blzhao@google.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
use-crds-in-dev-vms
branch
from
3935869
to
98b6b74
Compare
aanm
approved these changes
May 10, 2021
aanm
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the default development setup to match the Helm defaults as closely as possible, to facilitate onboarding of new contributors and ease the reproduction of issues, as described in #15367. Several options were changed with that in mind in #15367 but the development VMs still use the kvstore by default instead of relying on CRDs.
Reported-by: Bolun Zhao blzhao@google.com
Signed-off-by: Paul Chaignon paul@cilium.io