plugins/cilium-cni: fix aws-cni cni chaining #15915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-CNI seems to require more fields than the ones hard coded in Cilium
image. This patch adds the missing fields.
Error messages that might show up in pod describe are similar as:
```
network: invalid character '{' after top-level value
```
or
```
\n{\n \"code\": 100,\n \"msg\": \"add cmd: failed to assign an IP address to container\"\n}": invalid character '{' after top-level value
```
Signed-off-by: André Martins <andre@cilium.io>
aanm
added
release-note/bug
joestringer
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
This matches the reported fixes in aws/amazon-vpc-cni-k8s#1314 .
christarazi
approved these changes
Apr 29, 2021
|
test-me-please |
errordeveloper
approved these changes
Apr 29, 2021
|
@christarazi I had a quick look and couldn't easily find anything, it'd be helpful to know which version worked and which one broke. |
|
test-1.16-netnext (previous https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-net-next/409/) |
|
hitting #15998 |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.10
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.0-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS-CNI seems to require more fields than the ones hard coded in Cilium
image. This patch adds the missing fields.
Error messages that might show up in pod describe are similar as:
or
Signed-off-by: André Martins andre@cilium.io