Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix fragment tracking test on GKE #15959

Merged
merged 1 commit into from Apr 30, 2021

Conversation

pchaigno
Copy link
Member

The fragment tracking test was disabled on GKE because it is incompatible with endpoint routes. Until that incompatibility is fixed, we can disable endpoint routes when running on GKE.

Fixes: #14652.

The fragment tracking test was disabled on GKE because it is
incompatible with endpoint routes [1]. Until that incompatiblity is
fixed, we can disable endpoint routes when running on GKE.

1 - cilium#15958
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! needs-backport/1.9 labels Apr 30, 2021
@pchaigno pchaigno requested a review from a team as a code owner April 30, 2021 09:47
@pchaigno pchaigno requested review from a team, nbusseneau and joamaki April 30, 2021 09:47
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 Apr 30, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.7 Apr 30, 2021
@pchaigno pchaigno requested a review from qmonnet April 30, 2021 09:47
@pchaigno
Copy link
Member Author

test-gke

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@qmonnet qmonnet removed their assignment Apr 30, 2021
@nbusseneau nbusseneau removed their assignment Apr 30, 2021
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 30, 2021
@pchaigno
Copy link
Member Author

GKE is passing and team reviews are covered. Marking as ready to merge.

@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.7 May 7, 2021
@brb brb mentioned this pull request May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.7 May 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
1.9.7
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

CI: K8sServicesTest Checks service across nodes Supports IPv4 fragments failing with endpoint routes enabled
9 participants