New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encryption getting started guides for v1.10 #15961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --encryption flag of the Cilium CLI requires an additional argument (which for IPSec should be set to "ipsec"). Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
Use the "--encryption wireguard" CLI flag rather then manually setting the individual config map values Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Apr 30, 2021
jibi
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Apr 30, 2021
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Apr 30, 2021
jibi
added
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
area/encryption
Impacts encryption support such as IPSec, WireGuard, or kTLS.
labels
Apr 30, 2021
tgraf
approved these changes
Apr 30, 2021
jibi
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Apr 30, 2021
Skipping full CI tests as this PR is just updating docs |
jibi
removed
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Apr 30, 2021
qmonnet
approved these changes
Apr 30, 2021
jibi
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Apr 30, 2021
@rolinh per the slack announcement here, please don't forget to add I've added the label to this PR but if you have any others then you may want to double-check this, otherwise they will not make it into the v1.10 final release. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.0-rc2
May 13, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.0-rc2
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
area/encryption
Impacts encryption support such as IPSec, WireGuard, or kTLS.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.