Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encryption getting started guides for v1.10 #15961

Merged
merged 2 commits into from Apr 30, 2021

Conversation

jibi
Copy link
Member

@jibi jibi commented Apr 30, 2021

No description provided.

The --encryption flag of the Cilium CLI requires an additional argument
(which for IPSec should be set to "ipsec").

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
Use the "--encryption wireguard" CLI flag rather then manually setting
the individual config map values

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
@jibi jibi requested a review from a team as a code owner April 30, 2021 12:10
@jibi jibi requested a review from qmonnet April 30, 2021 12:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 30, 2021
@jibi jibi added the release-note/misc This PR makes changes that have no direct user impact. label Apr 30, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 30, 2021
@jibi jibi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. labels Apr 30, 2021
@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 30, 2021
@jibi
Copy link
Member Author

jibi commented Apr 30, 2021

Skipping full CI tests as this PR is just updating docs

@jibi jibi removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 30, 2021
@qmonnet qmonnet removed their assignment Apr 30, 2021
@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 30, 2021
@rolinh rolinh merged commit ec1790a into master Apr 30, 2021
@rolinh rolinh deleted the pr/jibi/gsg-encryption-docs-v1.10 branch April 30, 2021 18:37
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 Apr 30, 2021
@joestringer
Copy link
Member

@rolinh per the slack announcement here, please don't forget to add needs-backport/1.10 labels for v1.10-targeted PRs: https://cilium.slack.com/archives/C2B917YHE/p1619564366441400

I've added the label to this PR but if you have any others then you may want to double-check this, otherwise they will not make it into the v1.10 final release.

@brb brb mentioned this pull request May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

6 participants