Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubble: Fix Race in Hubble Consumer #15967

Merged
merged 1 commit into from
May 20, 2021

Commits on May 3, 2021

  1. hubble: Fix Race in Hubble Consumer

    When the hubble event consumer channel is full there is
    a possible race condition. The code was structured such that
    the consumer could end up losing the count of lost events, because
    it was updating the count without a lock. Additionally, it could
    reach a condition wherein it would reset the count and send a
    notification of recovery more than once.
    
    Finally, there was a log message for dropped events, but it was
    "debug" level event rather than the warning that it should be.
    
    Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
    nathanjsweet committed May 3, 2021
    Configuration menu
    Copy the full SHA
    c11c010 View commit details
    Browse the repository at this point in the history