test: Fix the search for VIPs in cilium service list
#15968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug/CI
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
In several different service tests, we check that cilium is handling or
not handling a service VIP. To that end, we search for the given VIP in
the output of 'cilium service list'. That output looks something like:
ID Frontend Service Type Backend
1 10.87.240.1:443 ClusterIP 1 => 35.247.116.7:443
2 10.87.245.217:443 ClusterIP 1 => 10.84.1.94:443
3 10.87.240.10:53 ClusterIP 1 => 10.84.1.175:53
2 => 10.84.1.28:53
4 10.87.241.252:80 ClusterIP 1 => 10.84.1.104:8080
Searching for the VIP directly in the output may return false positives
however. For instance, searching for 10.87.241.25 in the above would match
the last line when the IP doesn't actually match. Instead we should
search for " VIP:", that is, with anchors at the beginning and end of
the VIP.
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fix-search-vip-in-cilium-svc-list
branch
from
db2af87
to
0e112b8
Compare
|
k8s-1.21-kernel-4.9 is failing with known flake #15097. Other tests are passing. |
pchaigno
added
the
ready-to-merge
This was referenced May 7, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.0-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several different service tests, we check that cilium is handling or not handling a service VIP. To that end, we search for the given VIP in the output of
cilium service list. That output looks something like:Searching for the VIP directly in the output may return false positives however. For instance, searching for
10.87.241.25in the above would match the last line when the IP doesn't actually match. Instead we should search forVIP:, that is, with anchors at the beginning and end of the VIP.Fixes: #13752