Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/wireguard: Ensure allowedIPs are set as expected #16011

Merged

Conversation

gandro
Copy link
Member

@gandro gandro commented May 4, 2021

This introduces a check which uses cilium debuginfo to ensure that the
source and destination IPs of the test are set in Wireguard's allowedIPs
as expected. This avoids flakes both on the ingress or egress side in case
IPCache updates are delayed (which have been observed to be in the order
of seconds) by testing that the encryption channel is set up correctly before
we try send any traffic over it.

Fixes: #15974
Fixes: #15922

@gandro gandro added area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/ci This PR makes changes to the CI. labels May 4, 2021
@gandro
Copy link
Member Author

gandro commented May 4, 2021

test-1.16-netnext

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 4, 2021
This introduces a check which uses `cilium debuginfo` to ensure that the
source and destination IPs of the test are set as expected. This avoids
flakes both on the ingress or egress side in case IPCache updates are
delayed (which have been observed to be in the order of seconds) by
testing that the encryption channel is set up correctly before we try
send any traffic over it.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro force-pushed the pr/gandro/ci-address-wireguard-flakes branch from afe438e to ab4ca4e Compare May 5, 2021 10:51
@gandro
Copy link
Member Author

gandro commented May 5, 2021

test-1.16-netnext

@gandro gandro marked this pull request as ready for review May 5, 2021 14:15
@gandro gandro requested a review from a team May 5, 2021 14:15
@gandro gandro requested a review from a team as a code owner May 5, 2021 14:15
@gandro
Copy link
Member Author

gandro commented May 5, 2021

test-gke

@gandro
Copy link
Member Author

gandro commented May 5, 2021

test-1.19-5.4

@gandro
Copy link
Member Author

gandro commented May 5, 2021

test-1.20-4.19

@gandro
Copy link
Member Author

gandro commented May 5, 2021

test-1.21-4.9

@gandro
Copy link
Member Author

gandro commented May 5, 2021

test-runtime

@gandro
Copy link
Member Author

gandro commented May 6, 2021

@gandro
Copy link
Member Author

gandro commented May 6, 2021

retest-1.21-4.9

Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gandro gandro removed the request for review from borkmann May 6, 2021 08:10
@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 6, 2021
@jrajahalme jrajahalme merged commit 09c50c3 into cilium:master May 6, 2021
@brb brb mentioned this pull request May 7, 2021
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
7 participants