New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/wireguard: Ensure allowedIPs are set as expected #16011
Merged
jrajahalme
merged 1 commit into
cilium:master
from
gandro:pr/gandro/ci-address-wireguard-flakes
May 6, 2021
Merged
ci/wireguard: Ensure allowedIPs are set as expected #16011
jrajahalme
merged 1 commit into
cilium:master
from
gandro:pr/gandro/ci-address-wireguard-flakes
May 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
area/CI
Continuous Integration testing issue or flake
area/encryption
Impacts encryption support such as IPSec, WireGuard, or kTLS.
release-note/ci
This PR makes changes to the CI.
labels
May 4, 2021
test-1.16-netnext |
This introduces a check which uses `cilium debuginfo` to ensure that the source and destination IPs of the test are set as expected. This avoids flakes both on the ingress or egress side in case IPCache updates are delayed (which have been observed to be in the order of seconds) by testing that the encryption channel is set up correctly before we try send any traffic over it. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/ci-address-wireguard-flakes
branch
from
May 5, 2021 10:51
afe438e
to
ab4ca4e
Compare
test-1.16-netnext |
test-gke |
test-1.19-5.4 |
test-1.20-4.19 |
test-1.21-4.9 |
test-runtime |
christarazi
approved these changes
May 5, 2021
test-1.21-4.9 hit #13011 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/370/ |
retest-1.21-4.9 |
brb
approved these changes
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
gandro
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 6, 2021
qmonnet
approved these changes
May 6, 2021
aanm
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.0-rc2
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/encryption
Impacts encryption support such as IPSec, WireGuard, or kTLS.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a check which uses
cilium debuginfo
to ensure that thesource and destination IPs of the test are set in Wireguard's
allowedIPs
as expected. This avoids flakes both on the ingress or egress side in case
IPCache updates are delayed (which have been observed to be in the order
of seconds) by testing that the encryption channel is set up correctly before
we try send any traffic over it.
Fixes: #15974
Fixes: #15922