Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: filter out schedule events from forks #16012

Merged
merged 1 commit into from May 4, 2021

Conversation

nbusseneau
Copy link
Member

The general recommendation for forks is to disable Actions from the project settings, since most are contributionforks that don't need to run workflows in the context of the fork.

However, there are cases where one might need to enable Actions from a fork, e.g. for workflow development purposes. This change should alleviate workflow runs pressure for these instances.

The general recommendation for forks is to disable Actions from the
project settings, since most are contributionforks that don't need to
run workflows in the context of the fork.

However, there are cases where one might need to enable Actions from a
fork, e.g. for workflow development purposes. This change should
alleviate workflow runs pressure for these instances.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels May 4, 2021
@nbusseneau nbusseneau requested review from a team as code owners May 4, 2021 17:46
@nbusseneau nbusseneau added this to In progress in 1.10.0 May 4, 2021
@joestringer joestringer merged commit d15a701 into cilium:master May 4, 2021
1.10.0 automation moved this from In progress to Done May 4, 2021
@joestringer
Copy link
Member

@nbusseneau was this meant to be added to v1.10 project? It won't be in v1.10 unless we backport it.

@nbusseneau
Copy link
Member Author

@nbusseneau was this meant to be added to v1.10 project? It won't be in v1.10 unless we backport it.

No, this was a mistake. Good spot ;)

@nbusseneau nbusseneau removed this from Done in 1.10.0 May 5, 2021
@nbusseneau nbusseneau deleted the pr/workflows-filter-schedule branch May 10, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants