envoy: Add response headers access logging #16013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/enhancement
|
test-me-please |
|
gke-stable hit by a known unrelated flake: #16004, no other errors |
images/cilium/Dockerfile
Outdated
| @@ -8,7 +8,7 @@ ARG CILIUM_RUNTIME_IMAGE=quay.io/cilium/cilium-runtime:8fe001a11f25ad9e6676c19b0 | |||
|
|
|||
| # cilium-envoy from github.com/cilium/proxy | |||
| # | |||
| FROM quay.io/cilium/cilium-envoy:b3bb275dcaf4a74ae956e52fa408b196c0d52152@sha256:f3c7645c0ff1d7552b79927023cf540f82b40263780644f75291ed0bb1965bee as cilium-envoy | |||
| FROM quay.io/cilium/cilium-envoy-dev:59ac5af7d75273c2f2c0080be55eed4b07b4a1d8@sha256:48e6eb6024c84cc1114c7135bd42eb2e7797ec05d9366ae603a375a039f05188 as cilium-envoy | |||
There was a problem hiding this comment.
a very basic question but what's the difference between quay.io/cilium/cilium-envoy and quay.io/cilium/cilium-envoy-dev?
There was a problem hiding this comment.
cilium-envoy-dev repo has PR builds, cilium-envoy has master builds. We should not merge any cilium-envoy-dev builds, hence I kept this PR as a draft until now.
|
k8ss-1.16-kernel-netnext hit by known flake #12511, no other failures |
|
k8s-1.21-kernel-4.9 hit by known flake #15097, no other failures |
Use cilium-envoy image that adds response headers to response access log messages. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
envoy-accesslog-response-headers
branch
from
72882f5
to
ae65636
Compare
|
test-me-please |
michi-covalent
approved these changes
May 12, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.10
This was referenced May 13, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Needs backport from master
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Needs backport from master
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.0-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cilium-envoy image that adds response headers to response access
log messages.