Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Some Wireguard improvements #16023

Merged
merged 3 commits into from May 6, 2021
Merged

docs: Some Wireguard improvements #16023

merged 3 commits into from May 6, 2021

Conversation

brb
Copy link
Member

@brb brb commented May 5, 2021

See commit msgs.

@brb
docs: Move WG limitations to separate section
c4a6026 
To be consistent with other docs, e.g. the KPR GSG.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-blocker/1.10 labels May 5, 2021
@brb brb requested a review from gandro May 5, 2021 12:58
@brb brb requested a review from a team as a code owner May 5, 2021 12:58
@brb brb requested a review from qmonnet May 5, 2021 12:58
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 5, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 5, 2021
gandro
gandro approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gandro gandro added the release-note/misc This PR makes changes that have no direct user impact. label May 5, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 5, 2021
qmonnet
qmonnet approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Documentation/gettingstarted/encryption-wireguard.rst Outdated Show resolved Hide resolved
@brb
Copy link
Member Author

brb commented May 6, 2021

@gandro @qmonnet Thanks for the review. Marking as ready-to-merge.

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 6, 2021
brb added 2 commits May 6, 2021 10:38
@brb
docs: Add Wireguard troubleshooting section
4318c6f 
Also, mention "cilium status" in the validation steps.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
docs: Add note about pod2pod tunnel bypass
7f5c13b 
The full discussion is in
#15716 (comment).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@qmonnet
Copy link
Member

qmonnet commented May 6, 2021

Based on the release-blocker/1.10, I'm tagging for 1.10 backports.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 6, 2021
@jrajahalme jrajahalme merged commit c4c20f4 into master May 6, 2021
@jrajahalme jrajahalme deleted the pr/brb/wg-docs branch May 6, 2021 14:44
@brb brb mentioned this pull request May 7, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@aanm aanm mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brb @qmonnet @gandro @joestringer @jrajahalme