Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: minor improvements to tuning guide #16024

Merged
merged 1 commit into from May 5, 2021
Merged

docs: minor improvements to tuning guide #16024

merged 1 commit into from May 5, 2021

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented May 5, 2021

No description provided.

@borkmann borkmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels May 5, 2021
@borkmann borkmann requested review from jibi, tgraf and a team May 5, 2021 13:37
@borkmann borkmann requested a review from a team as a code owner May 5, 2021 13:37
@borkmann borkmann requested a review from qmonnet May 5, 2021 13:37
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 5, 2021
jibi
jibi approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@jibi jibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀 just a few minor nits

Documentation/operations/performance/tuning.rst Outdated Show resolved Hide resolved
Documentation/operations/performance/tuning.rst Outdated Show resolved Hide resolved
Documentation/operations/performance/tuning.rst Outdated Show resolved Hide resolved
Documentation/operations/performance/tuning.rst Outdated Show resolved Hide resolved
qmonnet
qmonnet approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@borkmann
docs: minor improvements to tuning guide
7edfcb8 
Various updates all over the place.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann merged commit d1f0c8e into master May 5, 2021
@borkmann borkmann deleted the pr/docs-tuning-guide branch May 5, 2021 19:42
@brb brb mentioned this pull request May 7, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@aanm aanm mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

@jrfastab jrfastab jrfastab approved these changes

@qmonnet qmonnet qmonnet approved these changes

@tgraf tgraf Awaiting requested review from tgraf

Assignees

@tgraf tgraf

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@borkmann @jibi @jrfastab @qmonnet @brb @joestringer @tgraf