Fix logging for expired FQDN IPs #16030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current logging has been implemented in cilium#14878 using Warning level. As reported in cilium#15935 this causes lots of log lines to be generated at each garbage collection cycle. The fix here is to move the log generation from Warning to Debug. Fixes: cilium#15935 Signed-off-by: Youssef Azrak <yazrak.tech@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
christarazi
approved these changes
May 6, 2021
christarazi
added
area/proxy
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
May 6, 2021
|
No need for more testing than the default GitHub actions. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
|
could we consider this PR to be back-ported in 1.10? |
|
Makes sense to me given it's a fix. I added the label. |
|
awesome, thanks @pchaigno! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logging has been implemented in #14878 using Warning level.
As reported in #15935 this causes lots of log lines to be generated at
each garbage collection cycle.
The fix here is to move the log generation from Warning to Debug.
Fixes: #15935
Signed-off-by: Youssef Azrak yazrak.tech@gmail.com