New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds IPv6 support for generic-veth chaining plugin #16041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
May 6, 2021
This comment has been minimized.
This comment has been minimized.
Verified that this pull request fixes #15789 |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
May 6, 2021
pchaigno
added
kind/bug
This is a bug in the Cilium logic.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
labels
May 6, 2021
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
May 6, 2021
pchaigno
reviewed
May 6, 2021
test-me-please |
test-me-please |
CI failures after rebasing is non-overlapping with failures previous to rebasing, I doubt this PR should cause any of these failures... |
pchaigno
requested changes
May 11, 2021
Weil0ng
force-pushed
the
v6
branch
2 times, most recently
from
May 21, 2021 22:37
78cf123
to
4e5d3be
Compare
pchaigno
requested changes
May 22, 2021
Weil0ng
force-pushed
the
v6
branch
2 times, most recently
from
May 26, 2021 18:11
81d5cb8
to
4dd3596
Compare
pchaigno
approved these changes
May 26, 2021
test-me-please |
Signed-off-by: Weilong Cui <cuiwl@google.com>
test-me-please |
aanm
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
This is a bug in the Cilium logic.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generic-veth chaining plugin only passes IPv4 address to the agent upon pod creation. This disrupts traffic for clusters with dual-stack/ipv6, as all v6 traffic would be identified as unknown sip in the datapath.
This adds the logic to parse v6 address when available and pass it to the agent.
Signed-off-by: Weilong Cui cuiwl@google.com
Fixes: #15789