Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds IPv6 support for generic-veth chaining plugin #16041

Merged
merged 1 commit into from Jun 3, 2021
Merged

Conversation

Weil0ng
Copy link
Contributor

@Weil0ng Weil0ng commented May 6, 2021

Currently the generic-veth chaining plugin only passes IPv4 address to the agent upon pod creation. This disrupts traffic for clusters with dual-stack/ipv6, as all v6 traffic would be identified as unknown sip in the datapath.

This adds the logic to parse v6 address when available and pass it to the agent.

Signed-off-by: Weilong Cui cuiwl@google.com

Fixes: #15789

@Weil0ng Weil0ng requested a review from a team May 6, 2021 20:21
@maintainer-s-little-helper

This comment has been minimized.

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 6, 2021
@Weil0ng Weil0ng requested a review from nebril May 6, 2021 20:21
@maintainer-s-little-helper

This comment has been minimized.

@Weil0ng Weil0ng marked this pull request as draft May 6, 2021 20:24
@Weil0ng Weil0ng marked this pull request as ready for review May 6, 2021 20:37
@sdmodi
Copy link

sdmodi commented May 6, 2021

Verified that this pull request fixes #15789

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 6, 2021
@pchaigno pchaigno added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 6, 2021
@Weil0ng
Copy link
Contributor Author

Weil0ng commented May 6, 2021

test-me-please

@Weil0ng
Copy link
Contributor Author

Weil0ng commented May 10, 2021

test-me-please

@Weil0ng
Copy link
Contributor Author

Weil0ng commented May 11, 2021

CI failures after rebasing is non-overlapping with failures previous to rebasing, I doubt this PR should cause any of these failures...

@Weil0ng Weil0ng force-pushed the v6 branch 2 times, most recently from 78cf123 to 4e5d3be Compare May 21, 2021 22:37
@Weil0ng Weil0ng force-pushed the v6 branch 2 times, most recently from 81d5cb8 to 4dd3596 Compare May 26, 2021 18:11
@pchaigno
Copy link
Member

test-me-please

Signed-off-by: Weilong Cui <cuiwl@google.com>
@Weil0ng
Copy link
Contributor Author

Weil0ng commented Jun 2, 2021

test-me-please

@aanm aanm removed the request for review from nebril June 3, 2021 19:43
@aanm aanm merged commit d5f5c10 into cilium:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 traffic being dropped for dual stack clusters.
5 participants