.github: Don't persist credentials in repository #16052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI-improvement
joestringer
approved these changes
May 7, 2021
I'd prefer if we can, yes. But it seems GitHub workflows are on strike in this PR... |
nbusseneau
requested changes
May 10, 2021
This is because of the syntax error outlined above: https://github.com/cilium/cilium/actions/runs/821429393 |
pchaigno
force-pushed
the
workflows-dont-persist-credentials
branch
from
a5b2f79
to
3933658
Compare
nbusseneau
requested changes
May 10, 2021
When using actions/checkout, the default behavior [1] is to persist git credentials in the checked out code. This is ill-advised, so let's disable with persist-credentials. 1 - https://github.com/actions/checkout#usage 2 - https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
workflows-dont-persist-credentials
branch
from
3933658
to
98fe2fb
Compare
|
Team reviews are in and all GitHub workflows are passing. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using actions/checkout, the default behavior [1] is to persist git credentials in the checked out code. This is ill-advised, so let's disable with
persist-credentials.1 - https://github.com/actions/checkout#usage
2 - https://securitylab.github.com/research/github-actions-preventing-pwn-requests/