test: Fix incorrect uninstall in K8sBandwidth #16053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The statement to uninstall Cilium in K8sBandwidth/AfterAll doesn't match the statements to install it, meaning we could try to disable Cilium even though we never installed it. This commit fixes it. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
|
The bandwidth manager is only tested on the net-next CI job: test-1.16-netnext |
kkourt
approved these changes
May 10, 2021
|
Failed due to timeout (https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-net-next/461/testReport/junit/Suite-k8s-1/16/K8sUpdates_Tests_upgrade_and_downgrade_from_a_Cilium_stable_image_to_master/), but I'm not seeing an up trend in the CI dashboard 🤔 test-1.16-netnext |
nebril
approved these changes
May 13, 2021
pchaigno
added
the
ready-to-merge
aanm
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.0-rc3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statement to uninstall Cilium in K8sBandwidth/AfterAll doesn't match the statements to install it, meaning we could try to disable Cilium even though we never installed it. This commit fixes it.
Fixes: #15132.