Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bpftool map dumps #16055

Merged
merged 1 commit into from May 28, 2021
Merged

Add missing bpftool map dumps #16055

merged 1 commit into from May 28, 2021

Conversation

h3llix
Copy link
Contributor

@h3llix h3llix commented May 7, 2021

Fixes:#16008

@h3llix h3llix requested a review from a team as a code owner May 7, 2021 20:22
@h3llix h3llix requested a review from errordeveloper May 7, 2021 20:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 7, 2021
aanm
aanm requested changes May 7, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, only 2 minor nits

bugtool/cmd/configuration.go Outdated Show resolved Hide resolved
bugtool/cmd/configuration.go Outdated Show resolved Hide resolved
bugtool/cmd/configuration.go Outdated Show resolved Hide resolved
@aanm aanm added needs-backport/1.8 release-note/misc This PR makes changes that have no direct user impact. labels May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.7 May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.10 May 7, 2021
@aanm aanm requested review from a team and kkourt and removed request for a team May 7, 2021 20:26
@h3llix
bugtool: add missing bpftool map dumps
e9ed5e7 
Fixes:cilium#16008

Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix h3llix requested a review from aanm May 7, 2021 20:38
kkourt
kkourt approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@joestringer joestringer added this to Needs backport from master in 1.8.11 May 13, 2021
@joestringer joestringer removed this from Needs backport from master in 1.8.10 May 13, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc2 May 17, 2021
@aanm
Copy link
Member

aanm commented May 17, 2021

test-me-please

@aanm aanm added this to Needs backport from master in 1.10.1 May 19, 2021
@aanm aanm removed this from Needs backport from master in 1.10.0-rc3 May 19, 2021
@aanm
Copy link
Member

aanm commented May 27, 2021

test-me-please

@aanm aanm added this to Needs backport from master in 1.9.9 May 27, 2021
@aanm aanm removed this from Needs backport from master in 1.9.8 May 27, 2021
@aanm aanm merged commit c573ff8 into cilium:master May 28, 2021
@qmonnet qmonnet mentioned this pull request Jun 1, 2021
Merged
23 tasks
@qmonnet qmonnet mentioned this pull request Jun 2, 2021
Merged
6 tasks
@gandro gandro mentioned this pull request Jun 10, 2021
Merged
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.1 Jun 16, 2021
@aanm aanm mentioned this pull request Jun 16, 2021
Merged
@Mierdin Mierdin mentioned this pull request Jun 29, 2021
Closed
@joestringer joestringer moved this from Needs backport from master to Backport done to v1.8 in 1.8.11 Jun 30, 2021
@joestringer joestringer moved this from Needs backport from master to Backport done to v1.9 in 1.9.9 Jul 19, 2021
This was referenced Jul 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno left review comments

@kkourt kkourt kkourt approved these changes

@errordeveloper errordeveloper errordeveloper approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.1
Backport done to v1.10
1.8.11
Backport done to v1.8
1.9.9
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@h3llix @aanm @kkourt @errordeveloper @pchaigno @gandro @qmonnet @aditighag